Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Use nearest resampling for merging temporal coherence #508

Merged

Conversation

scottstanie
Copy link
Collaborator

@scottstanie scottstanie commented Dec 3, 2024

Closes #144

The lanczos filter was leading to pixels above 1 in the merged temporal coherence image, despite the max being 1.0 per burst.

This is also likely the reason for negative coherences, though we can reopen if any new instances are spotted (hasn't been seen in a year)

Before the fix:

# per-burst coherence (min, max, mean, stddev)
$ rio info --stats scratch/historical/t034_071057_iw2/linked_phase/temporal_coherence_average_20160927_20170326.tif
0.10250737518072128 1.0 0.5941266093428491 0.16596814123869957

# Stitched
$ rio info --stats scratch/historical/interferograms/temporal_coherence.tif
0.01056671142578125 1.15234375 0.5833594791456398 0.19027603197546147

and these were only happening on bursts which required reprojection:

$ rio info --crs scratch/historical/interferograms/temporal_coherence.tif
EPSG:32615
$ rio info --crs scratch/historical/t034_071057_iw2/linked_phase/temporal_coherence_average_20160927_20170326.tif
EPSG:32614

Closes isce-framework#144

The `lanczos` filter was leading to pixels above 1 in the merged
temporal coherence image, despite the max being 1.0 per burst.

This is also likely the reason for negative coherences, though
we can reopen if any new instances are spotted (hasn't been seen in a
year)
@scottstanie scottstanie merged commit 207194f into isce-framework:main Dec 3, 2024
5 checks passed
@scottstanie scottstanie deleted the fix-stitching-temp-coh branch December 3, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal coherence has occasional pixel < 0
1 participant