configurable providerquerymanager #641
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/configurable-providequerymanager
branch
from
a6677c4
to
f538d1f
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 59.82% 59.77% -0.06%
==========================================
Files 238 238
Lines 29976 30045 +69
==========================================
+ Hits 17933 17958 +25
- Misses 10424 10470 +46
+ Partials 1619 1617 -2
|
…le to turn off the ProviderQueryManager
…add options, add WithMaxTimeout option
…rocessRequests option
aschmahmann
force-pushed
the
feat/configurable-providequerymanager
branch
from
f538d1f
to
e95eeb2
Compare
aschmahmann
commented
Jul 26, 2024
Comment on lines
81
to
+86
| FindProvidersAsync(ctx context.Context, k cid.Cid) <-chan peer.ID | ||
| } | ||
|
|
||
| type FindAllProviders struct { | ||
| Router bsnet.BitSwapNetwork | ||
| } |
There was a problem hiding this comment.
If we're going to keep the function here as not taking a count the name should get changed from FindProvidersAsync to one that doesn't collide with the more widely used function that does take a count so implementations can use both if they want.
aschmahmann
commented
Jul 26, 2024
Comment on lines
+91
to
+116
| provCh := make(chan peer.ID) | ||
| wg := &sync.WaitGroup{} | ||
| for p := range providers { | ||
| wg.Add(1) | ||
| go func(p peer.ID) { | ||
| defer wg.Done() | ||
| span.AddEvent("FoundProvider", trace.WithAttributes(attribute.Stringer("peer", p))) | ||
| err := r.Router.ConnectTo(ctx, p) | ||
| if err != nil { | ||
| span.RecordError(err, trace.WithAttributes(attribute.Stringer("peer", p))) | ||
| log.Debugf("failed to connect to provider %s: %s", p, err) | ||
| return | ||
| } | ||
| span.AddEvent("ConnectedToProvider", trace.WithAttributes(attribute.Stringer("peer", p))) | ||
| select { | ||
| case provCh <- p: | ||
| case <-ctx.Done(): | ||
| return | ||
| } | ||
| }(p) | ||
| } | ||
| go func() { | ||
| wg.Wait() | ||
| close(provCh) | ||
| }() | ||
| return provCh |
There was a problem hiding this comment.
Note: this was copied out of the ProviderQueryManager because the internals (or at least the tests) seem to rely on having the connections made explicit here. It seems reasonable to extract this up a level out of the routing component though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #640
This is an attempt at splitting the ProviderQueryManager out of Bitswap so that we can configure it more in consumers.