Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bitswap): wantlist overflow handling #629

Merged
merged 17 commits into from
Jul 30, 2024
Merged

fix(bitswap): wantlist overflow handling #629

merged 17 commits into from
Jul 30, 2024

Commits on Jul 3, 2024

  1. Fix wantlist overflow handling to select newer entries. 

    wantlist overflow handling now cancels existing entries to make room for newer requests. This fix prevents the wantlist from filling up with CIDs that the server does not have.

Fixes #527
    @gammazero
    gammazero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a06156c View commit details
    Browse the repository at this point in the history

  2. closer

    @gammazero
    gammazero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9c35f18 View commit details
    Browse the repository at this point in the history

  3. ignore 0 limit on peerledger wants

    @gammazero
    gammazero committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    eaf6667 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Handle wantlist overflow by selectively replacing existing wants 

    Handle incoming wants that could not be addded to the peer ledger without exceeding the peer want limit. These are handled by trying to make room for them by canceling existing wants for which there is no block. If this does not make sufficient room, then any lower priority wants that have blocks are canceled.
    @gammazero
    gammazero committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    25e948e View commit details
    Browse the repository at this point in the history

  2. Add comment for WithMaxQueuedWantlistEntriesPerPeer

    @gammazero
    gammazero committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3f54359 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. changes from review

    @gammazero
    gammazero committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    48a42c8 View commit details
    Browse the repository at this point in the history

  2. Fix race, do not sort wants unles overflow, and truncate over-limit w… 

    …ants
    @gammazero
    gammazero committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7c11036 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Add logging about overflow handling

    @gammazero
    gammazero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    994bd46 View commit details
    Browse the repository at this point in the history

  2. Add test to issustrate failure prior to this PR, and fix afterward

    @gammazero
    gammazero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    50421b4 View commit details
    Browse the repository at this point in the history

  3. Longer timeout for slow CI

    @gammazero
    gammazero committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ffd64ac View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'main' into fix/wantlist-overflow-handling

    @lidel
    lidel authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ece31b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Update bitswap/server/internal/decision/engine_test.go 

    Co-authored-by: Marcin Rataj <[email protected]>
    @gammazero @lidel
    gammazero and lidel authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    8664e38 View commit details
    Browse the repository at this point in the history

  2. Update bitswap/server/internal/decision/engine.go 

    Co-authored-by: Marcin Rataj <[email protected]>
    @gammazero @lidel
    gammazero and lidel authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0d1f8e1 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Co-authored-by: Marcin Rataj <[email protected]>
    @gammazero @lidel
    gammazero and lidel authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b016327 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/wantlist-overflow-handling

    @gammazero
    gammazero authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2faf741 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix/wantlist-overflow-handling

    @gammazero
    gammazero authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9c2759d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/wantlist-overflow-handling

    @gammazero
    gammazero authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d24abc7 View commit details
    Browse the repository at this point in the history