[v2.0] Move psk store to user

lets/src/id/identifier.rs

@@ -31,15 +31,11 @@ use spongos::{
 // Local
 #[cfg(feature = "did")]
 use crate::id::did::{DIDMethodId, DataWrapper};
-use crate::{
-    id::psk::{Psk, PskId},
-    message::{ContentEncrypt, ContentEncryptSizeOf, ContentVerify},
-};
+use crate::message::{ContentEncrypt, ContentEncryptSizeOf, ContentVerify};
 
 #[derive(Clone, Copy, Hash, PartialEq, Eq, PartialOrd, Ord)]
 pub enum Identifier {
     Ed25519(ed25519::PublicKey),
-    PskId(PskId),
     #[cfg(feature = "did")]
     DID(DIDMethodId),
 }
@@ -48,7 +44,6 @@ impl core::fmt::Debug for Identifier {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         match self {
             Self::Ed25519(arg0) => f.debug_tuple("Ed25519").field(&hex::encode(&arg0)).finish(),
-            Self::PskId(arg0) => f.debug_tuple("PskId").field(&hex::encode(arg0)).finish(),
             #[cfg(feature = "did")]
             Self::DID(arg0) => f.debug_tuple("DID").field(&hex::encode(arg0)).finish(),
         }
@@ -60,7 +55,6 @@ impl Identifier {
     pub(crate) fn as_bytes(&self) -> &[u8] {
         match self {
             Identifier::Ed25519(public_key) => public_key.as_slice(),
-            Identifier::PskId(id) => id.as_bytes(),
             #[cfg(feature = "did")]
             Identifier::DID(did) => did.as_ref(),
         }
@@ -86,10 +80,6 @@ impl Identifier {
     pub fn is_ed25519(&self) -> bool {
         matches!(self, Self::Ed25519(_))
     }
-
-    pub fn is_psk(&self) -> bool {
-        matches!(self, Self::PskId(_))
-    }
 }
 
 impl Default for Identifier {
@@ -105,18 +95,6 @@ impl From<ed25519::PublicKey> for Identifier {
     }
 }
 
-impl From<PskId> for Identifier {
-    fn from(pskid: PskId) -> Self {
-        Identifier::PskId(pskid)
-    }
-}
-
-impl From<Psk> for Identifier {
-    fn from(psk: Psk) -> Self {
-        Identifier::PskId(psk.to_pskid())
-    }
-}
-
 #[cfg(feature = "did")]
 impl From<&IotaDID> for Identifier {
     fn from(did: &IotaDID) -> Self {
@@ -156,14 +134,9 @@ impl Mask<&Identifier> for sizeof::Context {
                 self.mask(oneof)?.mask(pk)?;
                 Ok(self)
             }
-            Identifier::PskId(pskid) => {
-                let oneof = Uint8::new(1);
-                self.mask(oneof)?.mask(NBytes::new(pskid))?;
-                Ok(self)
-            }
             #[cfg(feature = "did")]
             Identifier::DID(did) => {
-                let oneof = Uint8::new(2);
+                let oneof = Uint8::new(1);
                 self.mask(oneof)?.mask(NBytes::new(did))?;
                 Ok(self)
             }
@@ -183,14 +156,9 @@ where
                 self.mask(oneof)?.mask(pk)?;
                 Ok(self)
             }
-            Identifier::PskId(pskid) => {
-                let oneof = Uint8::new(1);
-                self.mask(oneof)?.mask(NBytes::new(pskid))?;
-                Ok(self)
-            }
             #[cfg(feature = "did")]
             Identifier::DID(did) => {
-                let oneof = Uint8::new(2);
+                let oneof = Uint8::new(1);
                 self.mask(oneof)?.mask(NBytes::new(did))?;
                 Ok(self)
             }
@@ -212,13 +180,8 @@ where
                 self.mask(&mut pk)?;
                 *identifier = Identifier::Ed25519(pk);
             }
-            1 => {
-                let mut pskid = PskId::default();
-                self.mask(NBytes::new(&mut pskid))?;
-                *identifier = Identifier::PskId(pskid);
-            }
             #[cfg(feature = "did")]
-            2 => {
+            1 => {
                 let mut method_id = DIDMethodId::default();
                 self.mask(NBytes::new(&mut method_id))?;
                 let did = method_id.try_to_did()?;
@@ -291,17 +254,12 @@ where
 // TODO: Find a better way to represent this logic without the need for an additional trait
 #[async_trait(?Send)]
 impl ContentEncryptSizeOf<Identifier> for sizeof::Context {
-    async fn encrypt_sizeof(&mut self, recipient: &Identifier, exchange_key: &[u8], key: &[u8]) -> Result<&mut Self> {
-        match recipient {
-            Identifier::PskId(_) => self
-                .absorb(External::new(&NBytes::new(Psk::try_from(exchange_key)?)))?
-                .commit()?
-                .mask(NBytes::new(key)),
-            // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey introdution)
-            _ => match <[u8; 32]>::try_from(exchange_key) {
-                Ok(slice) => self.x25519(&x25519::PublicKey::from(slice), NBytes::new(key)),
-                Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
-            },
+    async fn encrypt_sizeof(&mut self, _recipient: &Identifier, exchange_key: &[u8], key: &[u8]) -> Result<&mut Self> {
+        // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey
+        // introdution)
+        match <[u8; 32]>::try_from(exchange_key) {
+            Ok(slice) => self.x25519(&x25519::PublicKey::from(slice), NBytes::new(key)),
+            Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
         }
     }
 }
@@ -312,17 +270,12 @@ where
     F: PRP,
     OS: io::OStream,
 {
-    async fn encrypt(&mut self, recipient: &Identifier, exchange_key: &[u8], key: &[u8]) -> Result<&mut Self> {
-        match recipient {
-            Identifier::PskId(_) => self
-                .absorb(External::new(&NBytes::new(Psk::try_from(exchange_key)?)))?
-                .commit()?
-                .mask(NBytes::new(key)),
-            // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey introdution)
-            _ => match <[u8; 32]>::try_from(exchange_key) {
-                Ok(byte_array) => self.x25519(&x25519::PublicKey::from(byte_array), NBytes::new(key)),
-                Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
-            },
+    async fn encrypt(&mut self, _recipient: &Identifier, exchange_key: &[u8], key: &[u8]) -> Result<&mut Self> {
+        // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey
+        // introdution)
+        match <[u8; 32]>::try_from(exchange_key) {
+            Ok(byte_array) => self.x25519(&x25519::PublicKey::from(byte_array), NBytes::new(key)),
+            Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
         }
     }
 }

lets/src/id/identity.rs

@@ -33,15 +33,14 @@ use spongos::{
 #[cfg(feature = "did")]
 use crate::id::did::{DataWrapper, DID};
 use crate::{
-    id::{ed25519::Ed25519, identifier::Identifier, psk::Psk},
+    id::{ed25519::Ed25519, identifier::Identifier},
     message::{ContentDecrypt, ContentSign, ContentSignSizeof},
 };
 
 #[derive(PartialEq, Eq, PartialOrd, Ord, Hash)]
 #[allow(clippy::large_enum_variant)]
 pub enum Identity {
     Ed25519(Ed25519),
-    Psk(Psk),
     #[cfg(feature = "did")]
     DID(DID),
 }
@@ -56,31 +55,11 @@ impl Default for Identity {
 
 impl Identity {
     // #[deprecated = "to be removed once key exchange is encapsulated within Identity"]
-    pub fn _ke_sk(&self) -> Option<x25519::SecretKey> {
+    pub fn _ke_sk(&self) -> x25519::SecretKey {
         match self {
-            Self::Ed25519(ed25519) => {
-                let x_secret: x25519::SecretKey = ed25519.inner().into();
-                Some(x_secret)
-            }
-            Self::Psk(_) => None,
-            #[cfg(feature = "did")]
-            Self::DID(DID::PrivateKey(info)) => Some(info.ke_kp().0),
-            #[cfg(feature = "did")]
-            Self::DID(DID::Default) => unreachable!(),
-            // TODO: Account implementation
-        }
-    }
-
-    // #[deprecated = "to be removed once key exchange is encapsulated within Identity"]
-    pub fn _ke(&self) -> [u8; 32] {
-        match self {
-            Self::Psk(psk) => psk.to_bytes(),
-            Self::Ed25519(ed25519) => {
-                let x_secret: x25519::SecretKey = ed25519.inner().into();
-                x_secret.to_bytes()
-            }
+            Self::Ed25519(ed25519) => ed25519.inner().into(),
             #[cfg(feature = "did")]
-            Self::DID(DID::PrivateKey(info)) => info.ke_kp().0.to_bytes(),
+            Self::DID(DID::PrivateKey(info)) => info.ke_kp().0,
             #[cfg(feature = "did")]
             Self::DID(DID::Default) => unreachable!(),
             // TODO: Account implementation
@@ -90,7 +69,6 @@ impl Identity {
     pub fn to_identifier(&self) -> Identifier {
         match self {
             Self::Ed25519(ed25519) => ed25519.inner().public_key().into(),
-            &Self::Psk(psk) => psk.into(),
             #[cfg(feature = "did")]
             Self::DID(did) => did.info().did().into(),
         }
@@ -103,12 +81,6 @@ impl From<Ed25519> for Identity {
     }
 }
 
-impl From<Psk> for Identity {
-    fn from(psk: Psk) -> Self {
-        Self::Psk(psk)
-    }
-}
-
 #[cfg(feature = "did")]
 impl From<DID> for Identity {
     fn from(did: DID) -> Self {
@@ -125,10 +97,9 @@ impl From<Identity> for Identifier {
 impl Mask<&Identity> for sizeof::Context {
     fn mask(&mut self, identity: &Identity) -> Result<&mut Self> {
         match identity {
-            Identity::Psk(psk) => self.mask(Uint8::new(0))?.mask(NBytes::new(psk)),
-            Identity::Ed25519(ed25519) => self.mask(Uint8::new(1))?.mask(NBytes::new(ed25519)),
+            Identity::Ed25519(ed25519) => self.mask(Uint8::new(0))?.mask(NBytes::new(ed25519)),
             #[cfg(feature = "did")]
-            Identity::DID(did) => self.mask(Uint8::new(2))?.mask(did),
+            Identity::DID(did) => self.mask(Uint8::new(1))?.mask(did),
         }
     }
 }
@@ -140,10 +111,9 @@ where
 {
     fn mask(&mut self, identity: &Identity) -> Result<&mut Self> {
         match identity {
-            Identity::Psk(psk) => self.mask(Uint8::new(0))?.mask(NBytes::new(psk)),
-            Identity::Ed25519(ed25519) => self.mask(Uint8::new(1))?.mask(NBytes::new(ed25519)),
+            Identity::Ed25519(ed25519) => self.mask(Uint8::new(0))?.mask(NBytes::new(ed25519)),
             #[cfg(feature = "did")]
-            Identity::DID(did) => self.mask(Uint8::new(2))?.mask(did),
+            Identity::DID(did) => self.mask(Uint8::new(1))?.mask(did),
         }
     }
 }
@@ -158,19 +128,13 @@ where
         self.mask(&mut oneof)?;
         match oneof.inner() {
             0 => {
-                let mut psk = Psk::default();
-                self.mask(NBytes::new(&mut psk))?;
-                *identity = Identity::Psk(psk);
-                Ok(self)
-            }
-            1 => {
                 let mut ed25519_bytes = [0; ed25519::SECRET_KEY_LENGTH];
                 self.mask(NBytes::new(&mut ed25519_bytes))?;
                 *identity = Identity::Ed25519(ed25519::SecretKey::from_bytes(ed25519_bytes).into());
                 Ok(self)
             }
             #[cfg(feature = "did")]
-            2 => {
+            1 => {
                 let mut did = DID::default();
                 self.mask(&mut did)?;
                 *identity = Identity::DID(did);
@@ -194,8 +158,6 @@ impl ContentSignSizeof<Identity> for sizeof::Context {
                 Ok(self)
             }
 
-            Identity::Psk(_) => Err(anyhow!("PSKs cannot be used as signature keys")),
-
             #[cfg(feature = "did")]
             Identity::DID(did_impl) => match did_impl {
                 DID::PrivateKey(info) => {
@@ -231,8 +193,6 @@ where
                 Ok(self)
             }
 
-            Identity::Psk(_) => Err(anyhow!("PSKs cannot be used as signature keys")),
-
             #[cfg(feature = "did")]
             Identity::DID(did_impl) => {
                 match did_impl {
@@ -279,17 +239,12 @@ where
     F: PRP,
     IS: io::IStream,
 {
-    async fn decrypt(&mut self, recipient: &Identity, exchange_key: &[u8], key: &mut [u8]) -> Result<&mut Self> {
-        match recipient {
-            Identity::Psk(_) => self
-                .absorb(External::new(&NBytes::new(Psk::try_from(exchange_key)?)))?
-                .commit()?
-                .mask(NBytes::new(key)),
-            // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey introduction)
-            _ => match <[u8; 32]>::try_from(exchange_key) {
-                Ok(byte_array) => self.x25519(&x25519::SecretKey::from_bytes(byte_array), NBytes::new(key)),
-                Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
-            },
+    async fn decrypt(&mut self, _recipient: &Identity, exchange_key: &[u8], key: &mut [u8]) -> Result<&mut Self> {
+        // TODO: Replace with separate logic for EdPubKey and DID instances (pending Identity xkey
+        // introduction)
+        match <[u8; 32]>::try_from(exchange_key) {
+            Ok(byte_array) => self.x25519(&x25519::SecretKey::from_bytes(byte_array), NBytes::new(key)),
+            Err(e) => Err(anyhow!("Invalid x25519 key: {}", e)),
         }
     }
 }

lets/src/id/psk.rs

@@ -31,14 +31,6 @@ impl Psk {
         spongos.sponge(seed)
     }
 
-    pub fn as_bytes(&self) -> &[u8] {
-        &self.0
-    }
-
-    pub(crate) fn to_bytes(self) -> [u8; 32] {
-        self.0
-    }
-
     pub fn to_pskid(self) -> PskId {
         let mut spongos = Spongos::<KeccakF1600>::init();
         spongos.absorb("PSKID");
@@ -80,10 +72,6 @@ impl PskId {
     {
         Psk::from_seed::<T>(seed).to_pskid()
     }
-
-    pub(crate) fn as_bytes(&self) -> &[u8] {
-        &self.0
-    }
 }
 
 impl AsRef<[u8]> for PskId {

spongos/src/lib.rs

@@ -1,7 +1,7 @@
 #![no_std]
 
 // Spongos requires heap allocation for Vectors and Strings
-#[cfg_attr(test, macro_use)]
+#[cfg_attr(all(test, not(feature = "std")), macro_use)]
 extern crate alloc;
 
 // Spongos requires the feature "std" for the Dump DDML command