Support for Nested @Embedded

[isaac-mercieca]

Fixed bug when generating the GraphQL schema for an Embeddable as the system was not taking into consideration having nested representations annotated with Embedded. By enhancing getEmbeddableType under GraphQLJpaSchemaBuilder so that generation is done in a recursive manner the system now supports an infinite amount of nestable classes annotated with Embedded.

Resolved #336

[igdianov]

Hi @isaac-mercieca, thanks for the PR! Could you, please, add unit tests to cover the fix?

[codecov]

Codecov Report

Patch coverage: 58.33% and project coverage change: -0.10 ⚠️

Comparison is base (49cebe5) 76.10% compared to head (49a98c2) 76.01%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #367      +/-   ##
============================================
- Coverage     76.10%   76.01%   -0.10%     
- Complexity     1133     1136       +3     
============================================
  Files            75       75              
  Lines          5081     5103      +22     
  Branches        732      732              
============================================
+ Hits           3867     3879      +12     
- Misses          890      899       +9     
- Partials        324      325       +1     

Impacted Files	Coverage Δ
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java	90.06% <58.33%> (-0.90%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[isaac-mercieca]

@igdianov I have added a test under BooksSchemaBuildTest to validate that the generated GraphQL schema includes a nested embeddable. While this validates the solution from a schema generation perspective which was initially failing, I do not know if an integration test should also be included. Seeing existing tests I noticed a test for EmbeddableIds which was approached differently from the rest.

[igdianov]

@isaac-mercieca The schema test looks good. Please, include an integration test with the query using embedded attributes in the where criteria and selection. This will bring the required test coverage threshold to pass codecov checks

[igdianov]

Need to have integration test to cover query execution