Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows w/pwsh installed for vmware train #721

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

rlakey
Copy link
Contributor

@rlakey rlakey commented Feb 10, 2022

Signed-off-by: rlakey [email protected]

Updated vmware transport to detect powershell before pwsh

Description

Fixes vmware transport on Windows systems with Powershell 6/7/Core installed

Related Issue

#720

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@rlakey rlakey requested a review from a team as a code owner February 10, 2022 19:41
@chef-expeditor
Copy link
Contributor

Hello rlakey! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Copy link
Contributor

@Vasu1105 Vasu1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rlakey
Copy link
Contributor Author

rlakey commented Jun 21, 2022

Any issues with getting this merged?

@clintoncwolfe clintoncwolfe merged commit 297634c into inspec:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants