Adds activesupport gem to allow XML>JSON parsing from Azure APIs

[ghost]

Signed-off-by: Ruairi Fennell [email protected]

Description

Adds activesupport gem to allow XML>JSON parsing from Azure APIs.
Had originally added this as a direct dependency to inspec-azure but users have been running into problems as resource-pack dependencies don't appear to be installed/bundled.

Related Issue

inspec/inspec-azure#216

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New content (non-breaking change)
• Breaking change (a content change which would break existing functionality or processes)

[chef-expeditor]

Hello r-fennell! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[codeclimate]

Code Climate has analyzed commit 9346053 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	3
Complexity	1

View more on Code Climate.

[miah]

Resource pack dependencies in Gemfiles are never installed.

This is the same problem we had with inspec-aws. Dependencies will need to be added to train (or a train-cloud) project before being added to inspec-cloud.

[zenspider]

Please drop a comment in there saying it is for inspec-azure.

[kekaichinose]

@miah thanks for the catch on this. @r-fennell I'll chat more with @skpaterson on this, but seems we need to keep a couple things in mind for changes to inspec-cloud repos going forward:

Short-Term
any time you add a gem to Gemfile for the specific inspec-cloud project, add a PR to appropriate train repository as well

Long-Term

• prioritize Train opt-in cloud provider transport design #529
  • probably need a discussion on who should own those child train- repos

[ghost]

@kekaichinose Thanks. I agree the current situation around dependencies isn't ideal and i'm glad #529 has got the ball rolling on addressing some of the shortcoming in the train>inspec>resource-pack development & release cycle.
Of course feel free to loop me in to any further discussions you plan on having with @skpaterson .