Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s client packages to fix skippy peanut butter #2816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohammadVatandoost
Copy link

Required checklist

  • Sample config files updated (both /etc folder and NewDemoConfig methods) (influxdb and plutonium)
  • openapi swagger.yml updated (if modified API) - link openapi PR
  • Signed CLA (if not already signed)

Description

An issue was discovered in Go Protobuf before 1.3.2 plugin/unmarshal/unmarshal.go lacks certain index validation, aka the "skippy peanut butter" issue.

Context

Update the k8s.io/client-go version to fix this issue.

Severity (optional)

i.e., ("recommend to upgrade immediately", "upgrade at your leasure", etc.)
immediately

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@mohammadVatandoost mohammadVatandoost force-pushed the fix-skippy-peanut-butter-issue branch from 89d50d8 to 9657e8f Compare April 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant