Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safe details and safe update-member #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add safe details and safe update-member #230

wants to merge 1 commit into from

Conversation

davidh-cyberark
Copy link

  • add safe details
  • add safe update-member
  • error string fixes in safes.go
  • bump version minor number
  • fix add-member example text

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

@infamousjoeg infamousjoeg self-requested a review December 10, 2024 13:28
infamousjoeg
infamousjoeg requested changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@infamousjoeg infamousjoeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just missing the updated docs for this.

To update docs and include it in your PR, from within the docs/ directory run:

go run main.go and it will update docs. Commit those here and we're good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infamousjoeg infamousjoeg infamousjoeg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidh-cyberark @infamousjoeg