Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to use props to retrieve event callbacks not attrs #1507

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

likeadeckofcards
Copy link

When using Vue Attrs over the component props we lose the capability to define the prop as camelcase or kebab-case. In most cases, this is fine. If you are using Eslint, one of the rules from the vuejs core team that is recommended/strongly-recommended is using kebab-case for component props in the template. By using the attrs to retrieve this data the end user cannot conform to eslint rules defined in their project. The following PR updates this functionality to use the props to retrieve the callbacks. The defaults for the props have been updated to match the intended definitions specified in the router class. This update removes the need to use the // @ts-expect-error comments in the render function.

@likeadeckofcards
Copy link
Author

@reinink or @claudiodekker would love to get your review of this update.

@likeadeckofcards
Copy link
Author

@reinink can you please take a look at this PR?

@ricardogobbosouza
Copy link

ricardogobbosouza commented Oct 19, 2023

I just had this problem

@pedroborges
Copy link
Collaborator

@likeadeckofcards Could you provide a reproducible repository or example that I can use to test the issue? It would really help in identifying the problem. Appreciate it!

@joetannenbaum joetannenbaum changed the base branch from master to v1 October 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants