Update link to use props to retrieve event callbacks not attrs #1507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Vue Attrs over the component props we lose the capability to define the prop as camelcase or kebab-case. In most cases, this is fine. If you are using Eslint, one of the rules from the vuejs core team that is recommended/strongly-recommended is using kebab-case for component props in the template. By using the attrs to retrieve this data the end user cannot conform to eslint rules defined in their project. The following PR updates this functionality to use the props to retrieve the callbacks. The defaults for the props have been updated to match the intended definitions specified in the router class. This update removes the need to use the
// @ts-expect-error
comments in the render function.