[1.x] remove IDE helpers from package #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztofrewak
changed the title
|
Yeah, having issues with this too. This feels like a developer preference and shouldn't be included in the repository or it's scope should be limited. |
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.1.0 release (with changes from #625) my IDE has a big problem with understanding where
Illuminate\Http\Requestis implemented.It looks like
[_ide_helpers.php](https://github.com/inertiajs/inertia-laravel/blob/1.x/_ide_helpers.php)is propagating its own classes into projects using Inertia.I believe that IDE helpers could be great if someone needs them, but they should be in scope of package only. They should not interfere with projects using these packages.
This should fix the problem.