Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables for SSR enabled and url options #624

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

bram-pkg
Copy link

Summary

  • Wrap the config values for inertia.ssr.enabled and inertia.ssr.url with environment variables:
    • INERTIA_SSR_ENABLED, with default value of true
    • INERTIA_SSR_URL, with default value of http://127.0.0.1:13714

Why?

As it would be nice to be able to configure these values out of the box based on environment variables (for example when running in Docker or Kubernetes), this makes it so people don't have to publish the configuration to edit these values. Nor does it require file system changes, cause ideally all external dependencies of an app should be able to be configured through environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant