Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used the
LevenbergMarquardtSolver
in a project. Despite the experience being very smooth overall, I noticed some typos and inconsistencies in the documentation that made using the class a bit inconvenient. This PR tries to fix most of those; in particular, I:computeSquaredError
andfit(<7 arguments>)
inLevenbergMarquardtSolver
in which the order of the arguments is consistent with the order of arguments in theFunctionFitter
interface andLevenbergMarquardtSolver
's constructor;Let me know if you think that makes sense or if I can do anything else.