Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy scanner code and changes from template repo #31

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

Mustaballer
Copy link
Contributor

@Mustaballer Mustaballer commented Oct 1, 2023

Overview

TODO:

  • QR code works successfully
  • need to test all edge cases from merging 30 files
  • resolve test cases

Unit Tests Created

  • n/a

Steps to QA

  1. submit an application as a participant
  2. on django admin site, approve application and give review decision date(otherwise might not work)
  3. sign in as participant and rsvp, and take a pic of the qr code
  4. modify SIGN_IN_TIMES in settings/__init__.py to play around with user activities(registration, lunch)
  5. sign in as admin user this time, and click on scan qr code button
  6. scan the qr code you screenshoted, and play around

If there is any questions, feel free to comment below.

@Mustaballer
Copy link
Contributor Author

I will resolve test cases failing in a seperate PR. Main features for scanning work. For testing the scanning feature, modify SIGN_IN_TIMES in settings/__init__.py.

@Mustaballer Mustaballer requested a review from natapokie October 23, 2023 00:22
Copy link

@natapokie natapokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected! sass is not working, but information shows up when qr code is scanned, and shows appropriate message.
image
image

just had one issue when trying to login from my test user account, looks like the login page has the "Email" label for the input and a validator for the '@' character, but the username is actually being queried in SQL?

for example if my username was testuser, and email was [email protected], I couldn't login when I used [email protected]. instead I had to rename the username to "testuser@" so that it had an '@' character in it and then I could login properly.

not sure if the username is meant to be the same as the email? i created a user via the admin page so that might've been why?

@Mustaballer
Copy link
Contributor Author

@natapokie yeah basically your usernames needs to be an email

@Mustaballer Mustaballer merged commit fd20127 into develop Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants