Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed usage of internal parts of the OkHttp3. #71

Conversation

tavar
Copy link
Contributor

@tavar tavar commented Apr 1, 2020

Replaced the calls of internals with direct interaction with the Android SDK without OkHttp in the middle.
Allow updating to newer versions of OkHttp.

Fixes #70

AnanthaKrish and others added 8 commits November 13, 2017 11:18
…bile-services/development

Updated to OKHttp3 version
…bile-services/development

Added App module
…bile-services/development

made changes in gradle, travis and test files
…bile-services/development

 removed the multidex
…bile-services/development

Added US East region
…bile-services/development

Added tokyo region
…bile-services/development

 removed unwanted header
Replaced the call with direct interaction with the Android SDK without OkHttp in the middle.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.49% when pulling 967c4c4 on tavar:removedInternalPartsOfOkHttp into 8db4f00 on ibm-bluemix-mobile-services:master.

@AnanthaKrish AnanthaKrish changed the base branch from master to development April 13, 2020 05:25
@AnanthaKrish
Copy link
Member

AnanthaKrish commented Apr 13, 2020

@tavar Merging the code to development branch . After testing will release a new version. Thank you.

@AnanthaKrish AnanthaKrish merged commit cd322cd into ibm-bluemix-mobile-services:development Apr 13, 2020
@Sadhvi-Nayak
Copy link

Sadhvi-Nayak commented Jul 2, 2020

@AnanthaKrish Is this in new version? facing this issue for push notification service.

java.lang.NoSuchFieldError: No static field UTF_8 of type Ljava/nio/charset/Charset; in class Lokhttp3/internal/Util; or its superclasses (declaration of 'okhttp3.internal.Util' appears in /data/app/<app>==/base.apk)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at com.ibm.mobilefirstplatform.clientsdk.android.core.internal.ResponseImpl.getResponseText(ResponseImpl.java:120)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at com.ibm.mobilefirstplatform.clientsdk.android.core.internal.ResponseImpl.toString(ResponseImpl.java:267)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at com.ibm.mobilefirstplatform.clientsdk.android.push.internal.MFPPushInvoker.onSuccess(MFPPushInvoker.java:97)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at com.ibm.mobilefirstplatform.clientsdk.android.core.api.Request$1.onResponse(Request.java:467)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at okhttp3.RealCall$AsyncCall.execute(RealCall.java:174)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
07-02 21:12:20.652 25962 26056 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:919)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with okhttp3 version >= 3.13.0
5 participants