Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with okhttp3 version >= 3.13.0 #70

Open
rotembr opened this issue Oct 3, 2019 · 1 comment · Fixed by #71
Open

Incompatibility with okhttp3 version >= 3.13.0 #70

rotembr opened this issue Oct 3, 2019 · 1 comment · Fixed by #71

Comments

@rotembr
Copy link
Contributor

rotembr commented Oct 3, 2019

The library uses internal parts of OkHttp3, namely
com.ibm.mobilefirstplatform.clientsdk.android.core.internal.ResponseImpl (34): import static okhttp3.internal.Util.UTF_8;
Using OkHttp3 internals is not a good practice. This was removed from OkHttp3 at version 3.13.0.

ref: ibm-cloud-security/appid-clientsdk-android#155
@rotembr rotembr mentioned this issue Oct 3, 2019
Open
@tavar
Copy link
Contributor

tavar commented Feb 26, 2020

I have the same problem. I have to use the AppID SDK and the Retrofit SDK within a project.
The new retrofit SDK offers a lot of great features which I don't want to miss.

Is there any progress to solve this problem?

@tavar tavar mentioned this issue Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed usage of internal parts of the OkHttp3. tavar/bms-clientsdk-android-core
2 participants
@tavar @rotembr