fix(duckdb): use simple GEOMETRY type for all geospatial data (#10324) #10333
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#10324) Ensure compatibility with DuckDB's implementation of geospatial types. Closes ibis-project#10324
|
Thanks @anjakefala ! Since this change is specific to the DuckDB backend, tests should go in For this particular fix, either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure compatibility with DuckDB's implementation of geospatial types.
I would love to add tests. Which is the appropriate test file?
Description of changes
In #10324 the temporary table generated the incorrect SQL definition of
GEOMETRY(POINT)instead of the simpleGEOMETRY. This ensures that the simpleGEOMETRYwill be used for all geospatial types.Issues closed