-
-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing existing fullscreen #8566
base: main
Are you sure you want to change the base?
Conversation
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace) this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
should this even be gated? |
i mean, someone didn't implement this at the first place for a reason, but I'll remove it |
binds:allow_replace_fullscreen
there is an issue now, if you have a fullscreen window and replace it with a floating pinned window, that originally fullscreened window won't restore back to fullscreen after un-fullscreening the floating pinned window. don't know how to fix |
try removing the pin status? unsure |
ahh, no one prob gonna notice anyway, how abt merge it for now and fix it if it turned into a more severe issue also rn theres a issue with pin that can be fixed with this(if u try to fullscreen the pinned window when another window is fullscreened, it'd mess up that var that stores the pin state). |
I don't think introducing issues on purpose is a good idea |
alright, then ill make a new var for storing if it was fullscreened before like what i did with pin_fullscreen |
Describe your PR, what does it fix/add?
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace)
this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
ready