Hw cursors fix for nvidia #6847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as I've said in the AQ MR, I'd rather use drm_dumb buffers for this if possible. Should be faster than a dataptr. |
|
I don't know how to use them and you don't seem to have enough time to deal with this issue. |
|
fair enough |
vaxerski
approved these changes
Jul 13, 2024
vaxerski
pushed a commit
that referenced
this pull request
Jul 13, 2024
* logging * fallback to dump cursor copy * unmap gbm buffer when done Signed-off-by: Vaxry <[email protected]>
vaxerski
pushed a commit
that referenced
this pull request
Jul 13, 2024
* logging * fallback to dump cursor copy * unmap gbm buffer when done Signed-off-by: Vaxry <[email protected]>
DawfukFR
pushed a commit
to DawfukFR/Hyprland
that referenced
this pull request
Jul 14, 2024
* logging * fallback to dump cursor copy * unmap gbm buffer when done Signed-off-by: Vaxry <[email protected]>
vaxerski
pushed a commit
that referenced
this pull request
Jul 20, 2024
* logging * fallback to dump cursor copy * unmap gbm buffer when done Signed-off-by: Vaxry <[email protected]>
vaxerski
pushed a commit
that referenced
this pull request
Jul 20, 2024
* logging * fallback to dump cursor copy * unmap gbm buffer when done Signed-off-by: Vaxry <[email protected]>
|
@UjinT34 any chance we could get scaling into this? |
|
@gulafaran worked on #7040 I don't have access to nvidia hardware atm. And I am not really interested in HW cursors without VRR #7386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds an option
cursor:allow_dumb_copyto allow dumb copy from cursor resource buffer to gbm buffer if rendering to gbm fails.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Works for me for the most part. Lacks some features (scaling at least). Only meant as a workaround to get hw cursors which is required to test direct scanout, vrr with hw cursors and explicit sync. Probably needs a better way of copying.
Is it ready for merging, or does it need work?
Requires hyprwm/aquamarine#12