Ros2 fix manager

[delihus]

Description

• Fixed install

Requirements

• Code style guidelines followed
• Documentation updated

Tests 🧪

• Robot
• Container
• Simulation

Summary by CodeRabbit

• New Features

  • Enhanced installation process for header files.
  • Introduced multiple new test executables for various nodes and functionalities, improving testing coverage.
  • Added integration test option for conditional compilation of specific tests.

• Bug Fixes

  • Improved reliability of functionalities through expanded testing.

• Documentation

  • Updated installation directives to ensure proper header file inclusion.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve modifications to the CMakeLists.txt file for the husarion_ugv_manager project. A new installation directive is added to ensure that the include/ directory is included during installation. Additionally, multiple new test executables are defined to enhance the testing framework, covering various nodes and functionalities. An integration test option is also introduced, allowing for conditional compilation of specific tests based on a defined option.

Changes

File	Change Summary
husarion_ugv_manager/CMakeLists.txt	- Added installation directive: install(DIRECTORY include/ DESTINATION include/)
	- Added multiple new test executables for various nodes and functionalities, including:
	- ${PROJECT_NAME}_test_call_set_bool_service_node
	- ${PROJECT_NAME}_test_call_trigger_service_node
	- ${PROJECT_NAME}_test_call_set_led_animation_service_node
	- ${PROJECT_NAME}_test_signal_shutdown_node
	- ${PROJECT_NAME}_test_shutdown_hosts_from_file_node
	- ${PROJECT_NAME}_test_tick_after_timeout_node
	- ${PROJECT_NAME}_test_shutdown_host
	- ${PROJECT_NAME}_test_shutdown_hosts_node
	- ${PROJECT_NAME}_test_shutdown_single_host_node
	- ${PROJECT_NAME}_test_behavior_tree_utils
	- ${PROJECT_NAME}_test_behavior_tree_manager
	- ${PROJECT_NAME}_test_lights_manager_node
	- ${PROJECT_NAME}_test_lights_behavior_tree
	- ${PROJECT_NAME}_test_safety_manager_node
	- ${PROJECT_NAME}_test_safety_behavior_tree
	- Introduced integration test option for conditional compilation of test_shutdown_single_host_node

Possibly related PRs

• Ros2 bt manager to hpp #461: This PR modifies the CMakeLists.txt file for the husarion_ugv_manager project, similar to the main PR, and includes changes to test definitions that are relevant to the enhancements made in the main PR.
• Added exporting include manager #464: This PR also updates the CMakeLists.txt file by adding an export directive for include directories, which relates to the installation changes made in the main PR.

Suggested reviewers

• KmakD
• rafal-gorecki

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ec21ac and b055376.

📒 Files selected for processing (1)

• husarion_ugv_manager/CMakeLists.txt (1 hunks)

🔇 Additional comments (4)

husarion_ugv_manager/CMakeLists.txt (4)

Line range hint 107-251: Well-structured test configuration with comprehensive coverage.

The test setup follows CMake and ROS2 best practices with:

• Proper use of ament_add_gtest
• Correct dependency and include directory configuration
• Good separation of unit and integration tests

---

Line range hint 146-155: Good practice: Integration tests are configurable.

The TEST_INTEGRATION option allows for flexible test execution, which is particularly useful in CI/CD pipelines where integration tests might need to be run separately.

---

104-104: LGTM: Installation directive properly added for header files.

The addition of install(DIRECTORY include/ DESTINATION include/) is correct and follows ROS2 package conventions. This fixes the installation of header files which is essential for packages that depend on this one.

Let's verify the header files that will be installed:

✅ Verification successful

Installation directive correctly added and header files structure verified

The install(DIRECTORY include/ DESTINATION include/) directive is correct and necessary. The package has a proper header files structure with multiple headers organized in subdirectories that need to be installed:

• Core headers like behavior_tree_manager.hpp, lights_manager_node.hpp
• Plugin headers in plugins/action/ and plugins/decorator/
  All these headers will be properly installed with the current directive, making them available for dependent packages.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: List header files that will be installed
# This helps verify the completeness of the installation

fd -e hpp -e h . include/

Length of output: 123

---

Script:

#!/bin/bash
# First, let's check if the include directory exists and its location
fd include

# Then, let's check the content of CMakeLists.txt to understand the context better
cat husarion_ugv_manager/CMakeLists.txt

Length of output: 9966

---

Script:

#!/bin/bash
# Let's check the contents of the include directory for this package
ls -R husarion_ugv_manager/include/

Length of output: 721

---

Line range hint 107-251: Reminder: Complete pending tests.

According to the PR description, tests for robot and simulation components are still pending. Please ensure these are addressed in a follow-up PR.

Let's check for any TODO comments or placeholders in the test files:

Would you like assistance in creating a GitHub issue to track the pending test implementations for robot and simulation components?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[BOOTCFG]

LGTM