Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to AzimuthIntervals #800

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Improvements to AzimuthIntervals #800

merged 15 commits into from
Nov 20, 2024

Conversation

tskisner
Copy link
Member

  • Use a more robust technique for computing the scan velocity and acceleration in the presence of noise and flags
  • Use a fit to the velocity for finding turnarounds
  • Add a unit test to generate plots and check that the expected number of scans is found

Example plot of scan properties found in the unit tests:
az_intervals

keskitalo
keskitalo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. More robust interval finding, backed by a unit test.

src/toast/ops/simple_jumpcorrect.py Show resolved Hide resolved
src/toast/utils.py Show resolved Hide resolved
@tskisner
Improvements to AzimuthIntervals
9455dcc 
Attempt to better handle azimuth data that is flagged
and data when the telescope is not scanning.
@tskisner
Improve robustness of numerical derivative in presence of noise and f…
513054b 
…lags. Add unit test.
@tskisner
Tweak polynomial order in turnaround finding
676c157
@tskisner
Fix bug when skipping zero-length objects from numpy.split
df170ff
@tskisner
Do not purge original data in demodulation unit tests, since we are m…
7ef3033 
…aking comparison plots of the original.
@tskisner
Fix typo
4aa9862
@tskisner
Pull common gap filling code out of multiple operators and place it i…
f934ea9 
…n utils.
@tskisner
Small tweak to support saving / loading jump information
8b1e95c
@tskisner
Fix a typo and use a better set of parameters for one case of gap fil…
c9d1200 
…ling.
@tskisner
Add small operator to wrap the gap filling utility. Change deglitch d…
1457057 
…efaults to not wipe exisiting detector flags.
@tskisner
Fix typo
fd7fe42
@tskisner
Debug test failure
045e6e5
@tskisner
Add unit test for gap filling. Also fix a flag interpretation issue.
98f919d
@tskisner
Add missing file
e2cb562
@tskisner
Tweak noise levels in azimuth data in unit tests
b65724c
@tskisner tskisner merged commit 92b4eed into toast3 Nov 20, 2024
7 checks passed
@tskisner tskisner deleted the so_fixes branch November 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keskitalo keskitalo keskitalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tskisner @keskitalo