feat: support classic-flavored ingest keys #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
added
type: enhancement
version: bump minor
cewkrupa
requested changes
Feb 28, 2024
cewkrupa
approved these changes
Feb 28, 2024
jharley
commented
Mar 1, 2024
| @@ -7,6 +8,12 @@ | |||
| from libhoney.transmission import Transmission | |||
|
|
|||
|
|
|||
| def IsClassicKey(key): | |||
There was a problem hiding this comment.
Not totally sure this belongs here? Happy to move it
jharley
commented
Mar 4, 2024
| @@ -84,9 +91,6 @@ def __init__(self, writekey="", dataset="", sample_rate=1, | |||
| if debug: | |||
| self._init_logger() | |||
|
|
|||
| def IsClassicKey(key): | |||
There was a problem hiding this comment.
It has been a hot minute since I did Python seriously, and I can't remember if this method ended up being public this way or not? If it is in fact public, I'll re-add it to call the above to avoid the breaking change
… evaluate as proper bools
MikeGoldsmith
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.
Short description of the changes
IsClassicKeya top level function exported fromlibhoneyto be used by the Python beeline