Add autoupdate frontend workflow #133
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
requested changes
Dec 11, 2024
| echo "Frontend version is up to date" | ||
| echo "skip=true" >> $GITHUB_OUTPUT | ||
| fi | ||
| - name: Check if there is no open PR with this version |
There was a problem hiding this comment.
Since all steps below here check for steps.check_version.outputs.skip != 'true', how about making this a workflow with two dependent jobs:
- check-version
- create-pr
This way we can consolidate the if statements.
Comment on lines
+49
to
+55
| - name: Close existing PRs of older version | ||
| if: steps.check_version.outputs.skip != 'true' && steps.check_existing_pr.outputs.skip != 'true' && steps.get_old_prs.outputs.old_prs_found == 'true' | ||
| run: | | ||
| apt-get install -y jq | ||
| for pr_number in $(jq -r '.[] | .number' <<< $OLD_PRS); do | ||
| gh pr close $pr_number --delete-branch --comment "Closed automatically because a newer frontend version is available" | ||
| done |
There was a problem hiding this comment.
Is this required?
I use the same GitHub action here: https://github.com/home-assistant-libs/chip-wheels/blob/main/.github/workflows/dependency-update.yaml#L43-L58
And the outcome is a continuously updated PR, which to me looks fine: home-assistant-libs/chip-wheels#117
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow to automate frontend updates.
For now there is no frontend release with the needed files