-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base entity to Spotify #128847
base: dev
Are you sure you want to change the base?
Add base entity to Spotify #128847
Conversation
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Co-authored-by: Christopher Fenner <[email protected]>
@@ -42,6 +43,7 @@ class SpotifyCoordinator(DataUpdateCoordinator[SpotifyCoordinatorData]): | |||
"""Class to manage fetching Spotify data.""" | |||
|
|||
current_user: UserProfile | |||
config_entry: ConfigEntry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this initialized somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the coordinator constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -117,18 +113,8 @@ def __init__( | |||
"""Initialize.""" | |||
super().__init__(coordinator) | |||
self.devices = device_coordinator | |||
|
|||
self._attr_unique_id = user_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user_id
is just handed in for the ID, what about moving this to the base entity as well? You could have a suffix for further entities in the future.
Proposed change
Add base entity to Spotify
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: