Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message format for get/set raw config #1117

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

MindFreeze
Copy link
Contributor

Format issue discovered by @AlCalzone zwave-js/certification-backlog#31 (comment)
I am confused as to how async_set_raw_config_parameter_value worked before but maybe it didn't 🤷‍♂️

@AlCalzone
Copy link
Contributor

I am confused as to how async_set_raw_config_parameter_value worked before but maybe it didn't 🤷‍♂️

It didn't - at least in my test.

Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests so they check this properly.

@MartinHjelmare MartinHjelmare marked this pull request as draft November 13, 2024 10:14
@MindFreeze MindFreeze marked this pull request as ready for review November 13, 2024 10:17
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit beaf847 into home-assistant-libs:master Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants