Added warning to ignoreWarnings.txt #889
Conversation
… unable to access <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/complete-code-system-4"> NCTS Complete CodeSystem</a> and <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/composed-value-set-4"> NCTS Composed ValueSet</a> for <a href="https://github.com/hl7au/au-fhir-base/issues/887">github-887</a>
input/pagecontent/changes.md
Outdated
| @@ -121,7 +121,8 @@ To help implementers, only the more significant changes are listed here. | |||
| </li> | |||
| <li>Updated AU Base ValueSet resources to remove conformance to HL7 International <a href="http://hl7.org/fhir/StructureDefinition/shareablevalueset">ShareableValueSet</a> and instead claim conformance to <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/composed-value-set-4"> NCTS Composed ValueSet</a> (<a href="https://jira.hl7.org/browse/FHIR-47149">FHIR-47149</a>) | |||
| </li> | |||
| <li>Removed codes from <a href="ValueSet-au-v3-ActEncounterCode-extended.html" >ActEncounterCode - AU Extended</a> (<a href="https://jira.hl7.org/browse/FHIR-47120">FHIR-47120</a>) | |||
| <li>Added Warnings to ignoreWarnings.txt for problems caused by validator unable to access <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/complete-code-system-4"> NCTS Complete CodeSystem</a> and <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/composed-value-set-4"> NCTS Composed ValueSet</a> for <a href="https://github.com/hl7au/au-fhir-base/issues/887">github-887</a></li> | |||
There was a problem hiding this comment.
change log is substantive changes for implementers, warnings that are suppressed are not considered substantive.
There was a problem hiding this comment.
Removed Warnings line
input/ignoreWarnings.txt
Outdated
| @@ -4,3 +4,7 @@ | |||
| The HTML fragment 'ip-statements.xhtml' is not included anywhere in the produced implementation guide | |||
| An HTML fragment from the set [cross-version-analysis.xhtml, cross-version-analysis-inline.xhtml] is not included anywhere in the produced implementation guide | |||
| The HTML fragment 'globals-table.xhtml' is not included anywhere in the produced implementation guide | |||
|
|
|||
| # === These warnings are suppressed as the validator cannot currently fetch the NCTS Codesystem and ValueSet profiles === | |||
There was a problem hiding this comment.
CI build does not ignore warnings (couple of exceptions) as that allows for continuous QA of both the IG and the toolchain. The release branches will ignore warnings.
What should be added, if the underlying source of the error will not be fixed in the very short term is an editorial note on how and when this will be fixed potentially with reference to a Jira or GitHub or zulip or some other tracker that provides evidence a fix is progressing..
There was a problem hiding this comment.
Updated suppression comment as per feedback
| @@ -121,7 +121,7 @@ To help implementers, only the more significant changes are listed here. | |||
| </li> | |||
| <li>Updated AU Base ValueSet resources to remove conformance to HL7 International <a href="http://hl7.org/fhir/StructureDefinition/shareablevalueset">ShareableValueSet</a> and instead claim conformance to <a href="https://healthterminologies.gov.au/fhir/StructureDefinition/composed-value-set-4"> NCTS Composed ValueSet</a> (<a href="https://jira.hl7.org/browse/FHIR-47149">FHIR-47149</a>) | |||
| </li> | |||
| <li>Removed codes from <a href="ValueSet-au-v3-ActEncounterCode-extended.html" >ActEncounterCode - AU Extended</a> (<a href="https://jira.hl7.org/browse/FHIR-47120">FHIR-47120</a>) | |||
There was a problem hiding this comment.
Changes to changes.md are outside the scope of this PR. Please remove (this file should not be included in the PR).
| @@ -4,3 +4,7 @@ | |||
| The HTML fragment 'ip-statements.xhtml' is not included anywhere in the produced implementation guide | |||
| An HTML fragment from the set [cross-version-analysis.xhtml, cross-version-analysis-inline.xhtml] is not included anywhere in the produced implementation guide | |||
| The HTML fragment 'globals-table.xhtml' is not included anywhere in the produced implementation guide | |||
|
|
|||
| # === These warnings are suppressed as the IG Publisher cannot validate code systems and value sets until a package dependency is available from NCTS. There is no timeline for completion of this enhancement. For more details see JIRA-48933 (https://jira.hl7.org/browse/FHIR-48933). === | |||
There was a problem hiding this comment.
I think it would be helpful to include more details about why the warnings appear - the IG Publisher cannot validate code systems and value sets against NCTS profiles because it cannot access them.
This is implied by the current note but not explicitly stated.
Added Warnings to ignoreWarnings.txt for problems caused by validator unable to access NCTS Complete CodeSystem and NCTS Composed ValueSet for github-887