-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/new/proposal form loads if chain data not loaded yet #3990
Conversation
b7f07d2
to
016afbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to know some constraints around when this hook is safe to use. Will it cause race conditions if e.g. app.chain is undefined? We should also document on the hook itself how to determine when it's complete & update dependent components.
016afbc
to
30eb50f
Compare
aed487e
to
b5d2e9b
Compare
@jnaviask Also added evmos "not supported" message per this discussion: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it still triggers a double init despite the hasFetched ref.
disable form on evmos add documentation to hook check if chain.preloading
ad97043
to
266a169
Compare
I removed the cleanup function. This was resetting the ref when I didn't expect it to. Now just running once. Also removed the check for preloading. Not needed. |
Link to Issue
Closes: #3988
Description of Changes
Test Plan
Deployment Plan
Other Considerations