Ignore updates from specified users / enable validation through HV / draft for handling automation events from downstream #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Nov 29, 2024
| } | ||
|
|
||
| @POST | ||
| @Path("/downstream/{project}") |
There was a problem hiding this comment.
Suggested change
| @Path("/downstream/{project}") | |
| @Path("/mirror/{project}") |
maybe?
| @@ -307,12 +312,40 @@ public void acknowledge(String project, JiraWebHookEvent event) { | |||
| throw new ConstraintViolationException("Project " + project + " is not configured.", Set.of()); | |||
| } | |||
|
|
|||
| if (context.isUserIgnored(triggeredByUser)) { | |||
| Log.infof("Event was triggered by %s user that is in the ignore list.", triggeredByUser); | |||
There was a problem hiding this comment.
Suggested change
| Log.infof("Event was triggered by %s user that is in the ignore list.", triggeredByUser); | |
| Log.tracef("Event was triggered by %s user that is in the ignore list.", triggeredByUser); |
Unless you want to be flooded, of course :]
| @@ -307,12 +312,40 @@ public void acknowledge(String project, JiraWebHookEvent event) { | |||
| throw new ConstraintViolationException("Project " + project + " is not configured.", Set.of()); | |||
| } | |||
|
|
|||
| if (context.isUserIgnored(triggeredByUser)) { | |||
There was a problem hiding this comment.
Note this means we will buffer a request body and deserialize the event before we check whether we ignore the request entirely (because of the user).
A potential improvement for later, to reduce the stress on the app, would be to implement this check as a filter instead. This might avoid the deserialization -- though probably not the buffering of the request body.
I say for later, because I'm not sure we even need such an optimization without our current workload :)
| context.startProcessingDownstreamEvent(); | ||
| doRun(); | ||
| } catch (RuntimeException e) { | ||
| failureCollector.critical("Failed to handled the event: %s".formatted(this), e); |
There was a problem hiding this comment.
Suggested change
| failureCollector.critical("Failed to handled the event: %s".formatted(this), e); | |
| failureCollector.critical("Failed to handle the event: %s".formatted(this), e); |
marko-bekhta
force-pushed
the
feat/validation-and-user-ignore
branch
from
478ba6d
to
224ca18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this a bit with JIRATEST1.