-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tiny-react): handle children re-insertion in fragment reconcilation #169
Open
hi-ogawa
wants to merge
15
commits into
refactor-tiny-react-reverse-insert-order
Choose a base branch
from
refactor-tiny-react-placeChild
base: refactor-tiny-react-reverse-insert-order
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(tiny-react): handle children re-insertion in fragment reconcilation #169
hi-ogawa
wants to merge
15
commits into
refactor-tiny-react-reverse-insert-order
from
refactor-tiny-react-placeChild
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
refactor(tiny-react): simplify
refactor(tiny-react): let parent vnode responsible for child re-insertion on mutation
Oct 19, 2023
placeChild
hi-ogawa
changed the title
refactor(tiny-react): let parent vnode responsible for child re-insertion on mutation
refactor(tiny-react): let parent responsible for child re-insertion on mutation
Oct 19, 2023
1 task
hi-ogawa
changed the base branch from
main
to
refactor-tiny-react-reverse-insert-order
October 19, 2023 14:08
…-tiny-react-placeChild
3 tasks
…-tiny-react-placeChild
hi-ogawa
changed the title
refactor(tiny-react): let parent responsible for child re-insertion on mutation
refactor(tiny-react): let fragment responsible for child re-insertion on mutation
Oct 21, 2023
4 tasks
…-tiny-react-placeChild
hi-ogawa
changed the title
refactor(tiny-react): let fragment responsible for child re-insertion on mutation
refactor(tiny-react): handle child re-insertion in fragment reconcilation
Oct 21, 2023
hi-ogawa
changed the title
refactor(tiny-react): handle child re-insertion in fragment reconcilation
refactor(tiny-react): handle children re-insertion in fragment reconcilation
Oct 21, 2023
…-tiny-react-placeChild
…-tiny-react-placeChild
…-tiny-react-placeChild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertBefore
#170Currently, each
VNode
itself is responsible for (re-)inserting itself even when "mutating" case by placeChildjs-utils/packages/tiny-react/src/reconciler.ts
Lines 78 to 99 in 49a5e3b
But, this is probably rather uncommon and had some issue with implementing
memo
based optimization (cf. #168).