Added documented fields to provision payload #84
Conversation
|
Closes #83 |
| @@ -281,9 +282,11 @@ def call! | |||
| :heroku_id => heroku_id, | |||
| :plan => data[:plan] || 'test', | |||
| :callback_url => callback, | |||
| :log_input_url => "https://token:[email protected]/logs", | |||
There was a problem hiding this comment.
I believe this field is not actually always present, but I think we should add a test case that runs for add-ons which have this enabled.
There was a problem hiding this comment.
@bjeanes yep, that's correct. The log_input_url value is only sent in the payload if the add-on service has log_input in its manifest: https://devcenter.heroku.com/articles/add-on-provider-log-integration#setup
What would the test case for sending log_input_url cover? That the provisioning service accepts the request including log_input_url without issue?
There was a problem hiding this comment.
It looks like the description in that link creates a structure(in the manifest) of
{ "api": { "requires": [ "log_input" ] } }
Is that correct? I'm new to add ons, so I've never seen it before.
There was a problem hiding this comment.
@nornholdj that's correct.
|
Hello! Have you tried https://github.com/heroku/heroku-cli-addons-admin ? Kensa is mostly deprecated, and I'd like to close this PR if the new CLI plugin works for you. |
No description provided.