Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguos medium-level API #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Levitanus
Copy link
Contributor

Here are functions I'm not sure in. Which are better to discuss.

@Levitanus
Copy link
Contributor Author

Considering Nudge I'm wondering in exact numbers for NudgeUnits.

Here is original API documentation:

nudgeunit: 0=ms, 1=seconds, 2=grid, 3=256th notes, ..., 15=whole notes, 16=measures.beats (1.15 = 1 measure + 1.5 beats), 17=samples, 18=frames, 19=pixels, 20=item lengths, 21=item selections

But, when I continued a sequence from 256th to 2th — I've finished on the literal 10, but not on the 14 as I would expect from docs.

I've never used nudge feature, so, here my expertise is out)

@Levitanus
Copy link
Contributor Author

Well, not as straight, as I desired...

  • get_set_project_info_string_set constantly returns false in any language. OK.
  • get_set_project_info_string_get fails in test with category TrackGroupName(x). But it works in my working instance of Reaper, when built from my extension.

Levitanus added a commit to Levitanus/reaper-rs that referenced this pull request Nov 15, 2022
It requires user to use `get_set_project_info_string_get` from the helgoboss#68.
Levitanus added a commit to Levitanus/reaper-rs that referenced this pull request Nov 15, 2022
It requires user to use `get_set_project_info_string_get` from the helgoboss#68.
It has some problems, which are not present in other languages implementations. See tests.
verbolize category string
`AudioAccessor` in ptr_wrappers.rs
`create_track_audio_accessor`
`create_take_audio_accessor`
`destroy_audio_accessor`
`audio_accessor_state_changed`
`audio_accessor_update`
`audio_accessor_validate_state`
`get_audio_accessor_end_time`
`get_audio_accessor_start_time`
`get_audio_accessor_samples`
`GetAudioAccessorHash` is not wrapped, as it is deprecated.
@Levitanus
Copy link
Contributor Author

Levitanus commented Nov 17, 2022

I feel, that AudioAccessor commit is OK. But, for the case, I put it here: not as straight, as typing arguments in right order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant