Add time zone support to chef-jenkins #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 12, 2012 17:35
…o be used as a JENKINS_JAVA_OPTIONS argument.
…t to have an option to run headless and another for the time zone (which is captured from node.jenkins.time_zone)
…ysconfig/jenkins and then link /etc/default/jenkins to /etc/sysconfig/jenkins. This ensures that if jenkins is restarted via service at the command line, then we will use the same jenkins config file that is used when jenkins is started by chef.
|
See #23 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made changes to chef-jenkins to support the addition of a time zone attribute (node.jenkins.time_zone). This allows you to configure the jenkins time zone via chef.
In the process, of working this issue, I also discovered that if you restart a chef-jenkins install of jenkins using the service command, that a different config file (/etc/sysconfig/jenkins) vs. the config file created by chef-jenkins.
To address this issue, I have modified jenkins::default to remove the config file at /etc/sysconfig/jenkins and link it to /etc/default/jenkins.
I believe these are positive additions to chef-jenkins. Hopefully, you will accept them.