Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Use fully qualified attribute names #107

Closed

Conversation

Meatballs1
Copy link
Collaborator

Resolves #72

This is a breaking change that means manually configured MQTT configurations in HA will need updating. I don't have much experience running this with HADiscovery enabled so would be good to get some feedback if further changes are required for that.

For example the SetpointTemperature in the following:

number:
  - name: "Set Point Temperature"
    unique_id: "freezer_set_point_temperature"
    state_topic: "homeconnect/freezer/state"
    value_template: "{{ value_json.SetpointTemperature }}"
    command_topic: "homeconnect/freezer/set"
    command_template: "[{\"uid\":8198,\"value\": {{ value }} }]"
    min: -26
    max: -16
    icon: mdi:snowflake-thermometer
    unit_of_measurement: "°C"
    availability:
      - topic:  "homeconnect/LWT"
      - topic:  "homeconnect/freezer/LWT"
    availability_mode: all
    device:
      identifiers: "freezer"

Needs to become:


number:
  - name: "Set Point Temperature"
    unique_id: "freezer_set_point_temperature"
    state_topic: "homeconnect/freezer/state"
    value_template: "{{ value_json['Refrigeration.Common.Setting.Freezer.SetpointTemperature'] }}"
    command_topic: "homeconnect/freezer/set"
    command_template: "[{\"uid\":8198,\"value\": {{ value }} }]"
    min: -26
    max: -16
    icon: mdi:snowflake-thermometer
    unit_of_measurement: "°C"
    availability:
      - topic:  "homeconnect/LWT"
      - topic:  "homeconnect/freezer/LWT"
    availability_mode: all
    device:
      identifiers: "freezer"

@Meatballs1 Meatballs1 marked this pull request as draft November 6, 2024 19:07
@Meatballs1 Meatballs1 closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous Attribute Naming
1 participant