Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have projects import trimmed URIs #10629

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Dec 9, 2024

Fixes #10622. Trims URIs before parsing them with parseURI. If any project config path doesn't equal its trimmed self then it is displayed quoted so that the whitespace is obvious.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@ulysses4ever
Copy link
Collaborator

Will need a changelog but otherwise it looks like the right direction overall.

@philderbeast philderbeast force-pushed the fix/project-untrimmed-url branch 3 times, most recently from 0021e35 to 4ebca6f Compare December 9, 2024 16:38
@geekosaur
Copy link
Collaborator

Huh. First time I've seen RTD fail that way.

@philderbeast
Copy link
Collaborator Author

Huh. First time I've seen RTD fail that way.

And I didn't change the docs. @geekosaur, other CI jobs I can restart but not that one.

@geekosaur
Copy link
Collaborator

That's normal, since RTD isn't actually part of GitHub Actions. You'll need to change something somewhere to trigger a new build, though. (You may want to hold off a bit though, to let RTD fix whatever's wrong on their end.)

@philderbeast philderbeast force-pushed the fix/project-untrimmed-url branch from e27511e to 50b9a2e Compare December 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cabal treats url with trailing whitespace in import cabal.project file as a file path
3 participants