-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have projects import trimmed URIs #10629
base: master
Are you sure you want to change the base?
Conversation
Will need a changelog but otherwise it looks like the right direction overall. |
0021e35
to
4ebca6f
Compare
- Don't do any file path manipulations for URLs
- Use with-ghc.config trick
4ebca6f
to
e27511e
Compare
Huh. First time I've seen RTD fail that way. |
And I didn't change the docs. @geekosaur, other CI jobs I can restart but not that one. |
That's normal, since RTD isn't actually part of GitHub Actions. You'll need to change something somewhere to trigger a new build, though. (You may want to hold off a bit though, to let RTD fix whatever's wrong on their end.) |
e27511e
to
50b9a2e
Compare
Fixes #10622. Trims URIs before parsing them with
parseURI
. If any project config path doesn't equal its trimmed self then it is displayed quoted so that the whitespace is obvious.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.cabal-testsuite
tests.