This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Get credential from Cattle's service account #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcanevet
changed the title
|
@raphink @cloudnautique ready to review. |
ghost
added
the
|
@raphink could you please review this? The idea is to be able to deploy stack from a CI that would run on an environment without needing to pass credentials. For example we could have a small DroneCI container in every Rancher environment that could be used by our developers to deploy their stacks. |
raphink
reviewed
Oct 29, 2018
| // Override with new environment variables | ||
| apiURL = d.Get("cattle_url").(string) | ||
| accessKey = d.Get("cattle_access_key").(string) | ||
| secretKey = d.Get("cattle_secret_key").(string) |
There was a problem hiding this comment.
Why duplicate the keys if they have exactly the same role?
There was a problem hiding this comment.
So that we can use the environment variables provided by cattle
|
@mcanevet do you still want to merge this? |
|
If it does not break what exists, yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #76