ci: use primary Go version to run Nomad and Vault integration tests #20124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we defer to other projects w.r.t. how they are built, we should run our tests (and Consul code) using the current latest version we declare. Follow-up to #20058.
zalimeni
added
pr/no-changelog
github-actions
bot
added
type/ci
zalimeni
commented
Jan 16, 2024
Comment on lines
-180
to
-183
| - uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1 | ||
| with: | ||
| # Do not explicitly set Go version here, as it should depend on what Vault declares. | ||
| go-version-file: 'go.mod' |
There was a problem hiding this comment.
At first I thought these tests were doing the same thing, but after looking more closely, this one installs the compiled binary directly from our releases page, so we only need the "local" Go version for running tests below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we defer to other projects w.r.t. how they are built, we should run our tests (and Consul code) using the current latest version we declare.
Follow-up to #20058.
PR Checklist