Improve Consensus logic for Multi-BLS Validators with quorum

[GheisMohammadi]

Issue

This PR improves the consensus logic to handle cases where validators with multiple BLS keys achieve quorum on their initial signatures or commits. Currently, such scenarios can block phase transitions because the condition if !quorumWasMet && quorumIsMet doesn't account for quorum being achieved immediately.

To fix this, a new function, checkFirstReceivedSignature, is introduced. It checks whether quorum is reached on the first batch of signatures or commits. The PR also updates the logic for Prepare and Commit phases to properly handle these edge cases. The PR helps to better handling of multi-BLS key validators while maintaining compatibility with single-key setups.

[sophoah]

@GheisMohammadi i am good with that PR. Can you do run the same logic with isFirstReceivedSignature for onPrepare ? and use it here

harmony/consensus/leader.go

Line 124 in 3b6fde4

if consensus.decider.IsQuorumAchieved(quorum.Prepare) {

? It prevent doing the return when the leader node already has quorum on the first onPrepare. Goal is to run didReachPrepareQuorum

harmony/consensus/leader.go

Line 188 in 3b6fde4

if err := consensus.didReachPrepareQuorum(); err != nil {

[GheisMohammadi]

@GheisMohammadi i am good with that PR. Can you do run the same logic with isFirstReceivedSignature for onPrepare ? and use it here

harmony/consensus/leader.go

Line 124 in 3b6fde4

if consensus.decider.IsQuorumAchieved(quorum.Prepare) {

? It prevent doing the return when the leader node already has quorum on the first onPrepare. Goal is to run didReachPrepareQuorum

harmony/consensus/leader.go

Line 188 in 3b6fde4

if err := consensus.didReachPrepareQuorum(); err != nil {

done

[sophoah]

old code was fine, as we just need consensus.didReachPrepareQuorum() to hit once

[GheisMohammadi]

I removed return. So, it allows adding new signatures in Prepare Phase despite existing quorum. I think this would fix the issue

[sophoah]

could you add PR description, and is this something we can write unit test (for onPrepare and onCommit) here as well ?

[sophoah]

@Frozen please review/approve

[sophoah]

@GheisMohammadi please update PR description

[GheisMohammadi]

@GheisMohammadi please update PR description

done

[sophoah]

updated this PR to "ready for review"
@Frozen please review/approve

[Frozen]

should i run it with make debug-multi-bls or debug-ext or debug?

[sophoah]

@Frozen you should run it with debug-multi-bls as it fixes a bug that only happens when using multi-bls and when the harmony node have quorum

[Frozen]

rebase pls branch on dev