Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Remove renderSingleLineWithItems #3065

Open
wants to merge 12 commits into
base: beta
Choose a base branch
from
Open

Backend: Remove renderSingleLineWithItems #3065

wants to merge 12 commits into from

Conversation

appable0
Copy link
Contributor

@appable0 appable0 commented Dec 14, 2024 •
edited
Loading

Dependencies

What

Removes deprecated RenderUtils method renderSingleLineWithItems, which was only used by one class after the changes made by the dependent PR.

Changelog Technical Details

  • Removed deprecated method; moved raffle event overlay to a renderable. - appable0

j10a1n15 and others added 12 commits November 29, 2024 21:00
@j10a1n15
move next jacob contest
adc3a19 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
move garden best crop display
a28b574 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
rename method
d280b48 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
fix rename method
72398cf 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
i love detekt so much
60a15b4 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
fuck it get moved aswell
06f7198 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
no, index++ doesnt work here
4145190 
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15
move additemstack next to each other
f99435f 
Signed-off-by: J10a1n15 <[email protected]>
@CalMWolfs
Merge branch 'beta' into backend/cropicon
4cc269c
@CalMWolfs
Merge branch 'beta' into backend/cropicon
e88d99d
@CalMWolfs
Merge branch 'refs/heads/beta' into fork/j10a1n15/backend/cropicon
f07e88c 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenBestCropTime.kt
@appable0
remove renderSingleLineWithItems
1730c27
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Dec 14, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with 'Removed' instead of 'Remove' in text: Remove deprecated method; move raffle event overlay to a renderable.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 14, 2024
@hannibal002 hannibal002 added the Waiting on Dependency PR waiting for a dependency pr to be merged label Dec 14, 2024
@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon Waiting on Dependency PR waiting for a dependency pr to be merged
Projects
None yet
Milestone
Version 0.29
Development

Successfully merging this pull request may close these issues.
4 participants
@appable0 @hannibal002 @j10a1n15 @CalMWolfs