Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Allow Parameterless Handling of SkyHanniEvent(s) #3064

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Dec 14, 2024

What

For the cases where @HandleEvent is needed solely as the starter for a code snippet, where the normal event: ... function construction would warn about an unused param.
Probably the most divisive PR I've opened :D

Images

Screenshot 2024-12-14 030819

Screenshot 2024-12-14 030346

Changelog Technical Details

  • SkyHanniEvents can now be @Handle-d without an event: parameter. - Daveed
    • New alternate annotation is @HandleEvent([ClassThatExtendsSkyHanniEvent]::class).

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Dec 14, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + SkyHanniEvents can now be @handle-d without an event: parameter.
Change should start with a letter instead of a number or special character in text: ``SkyHanniEvents can now be @Handle`-d without an `event:` parameter.`
Extra info without a change in text: ` * `@HandleEvent(eventType = [ClassThatExtendsSkyHanniEvent]::class)`.`

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Wrong Title/Changelog There is an error in the title or changelog Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Dec 14, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 14, 2024
@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants