-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix + Feature: Chocolate Factory Party Time 🥳️🌈 #3054
Open
DavidArthurCole
wants to merge
22
commits into
hannibal002:beta
Choose a base branch
from
DavidArthurCole:PartyTime
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
added
the
Waiting on Dependency PR
waiting for a dependency pr to be merged
label
Dec 13, 2024
github-actions
bot
added
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Dec 13, 2024
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Dec 13, 2024
github-actions
bot
added
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Dec 15, 2024
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Dec 15, 2024
Conflicts have been resolved! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Because this started as an accident while I was trying to do something else:
And because the date-time will need to get party-ified:
What
Adds a party mode to the chocolate factory.
The images below are after I've merged it into the other on-going Hoppity PRs.
On a more serious note this will also fix an issue with the stray flash would be "over" the top of other items rendered in CF due to having an unstable priority.
Images
https://imgur.com/a/1HXOW7q
Changelog New Features
Changelog Fixes