-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new project from admin #52
base: main
Are you sure you want to change the base?
Conversation
It is related to #39 /cc @davydovanton |
I think we can refactor internals of service methods |
oh, sorry, I missed this PR. Will check it ASAP. Sorry again 😞 |
@davydovanton no problem. Check it when you can. |
You don’t have to apologize. Really. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for me. I'll play with it locally and after that merge. Thanks for your work!
also, could you fix sidekiq specs? Just use |
@davydovanton Do you understand the Ruby version related error? I don't experience this locally. Other than that I have one error left:
and I can't understand why either. |
hey, sorry for the long delay. I think the issue in this line: = render partial: 'shared/navbar' Also, you can try to remove (or comment this spec: https://github.com/hanami/contributors/blob/master/spec/admin/views/application_layout_spec.rb#L9) |
Wow what the Don't have this locally, it's |
Seems like it was introduced later |
…hanges and update table
Ensure that when a project is added in admin it spawns a new background job to add contributors and their commits for the given project.
b7117a8
to
1a89143
Compare
@davydovanton Here we are. Everything seems fine now. |
Add form for adding a new project and spawn a sidekiq worker to import all new contributors and commits for the given project.