Cleanup zip file on error (#40)

hacs · Dec 8, 2023 · e877bba · e877bba
1 parent e7607b9
commit e877bba
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -68,6 +68,9 @@ jobs:
           if [ ! -f "${{ matrix.target.path }}/custom_components/hacs/manifest.json" ]; then
             exit 1
           fi
+          if [ -f "${{ matrix.target.path }}/custom_components/hacs.zip" ]; then
+            exit 1
+          fi
 
 
   version:
@@ -117,4 +120,9 @@ jobs:
         run: |
           if [ -f "./custom_components/hacs/manifest.json" ]; then
             exit 1
+          fi
+      - name: 👀 Verify cleanup
+        run: |
+          if [ -f "${{ matrix.target.path }}/custom_components/hacs.zip" ]; then
+            exit 1
           fi
diff --git a/get b/get
@@ -61,6 +61,7 @@ if [ -n "$haPath" ]; then
     cd "$haPath/custom_components" || error "Could not change path to $haPath/custom_components"
 
     info "Downloading HACS"
+    rm -f "$haPath/custom_components/hacs.zip"
     wget "https://github.com/hacs/integration/releases/latest/download/hacs.zip"
 
     if [ -d "$haPath/custom_components/hacs" ]; then
@@ -87,6 +88,7 @@ if [ -n "$haPath" ]; then
 
     if [ "${currentYear}" -lt "${targetYear}" ]; then
         rm -R "$haPath/custom_components/hacs"
+        rm -f "$haPath/custom_components/hacs.zip"
         error "Version ${currentVersion} is not new enough, needs at least ${targetVersion}"
     fi
 
@@ -96,11 +98,13 @@ if [ -n "$haPath" ]; then
 
         if [ "${currentYear}.${currentMonth}" == "2023.12" ]; then
             rm -R "$haPath/custom_components/hacs"
+            rm -f "$haPath/custom_components/hacs.zip"
             error "HACS will currently not work on ${currentYear}.${currentMonth} versions of Home Assistant, latest known working version is 2023.11.3"
         fi
 
         if [ "${currentMonth}" -lt "${targetMonth}" ]; then
             rm -R "$haPath/custom_components/hacs"
+            rm -f "$haPath/custom_components/hacs.zip"
             error "Version ${currentVersion} is not new enough, needs at least ${targetVersion}"
         fi
 
@@ -110,14 +114,15 @@ if [ -n "$haPath" ]; then
 
             if [ "${currentPatch}" -lt "${targetPatch}" ]; then
                 rm -R "$haPath/custom_components/hacs"
+                rm -f "$haPath/custom_components/hacs.zip"
                 error "Version ${currentVersion} is not new enough, needs at least ${targetVersion}"
             fi
         fi
     fi
 
     echo
     info "Removing HACS zip file..."
-    rm "$haPath/custom_components/hacs.zip"
+    rm -f "$haPath/custom_components/hacs.zip"
     info "Installation complete."
     echo
     info "Remember to restart Home Assistant before you configure it"