Adds the oauth signup url as an option #161
Conversation
Adds support for the oauth_signup_url via the bldr.env.sample file. Signed-off-by: skylerto <[email protected]>
|
Ah nice, this is literally the work I started yesterday :) I'm 👍 to merging this, but to clarify - this doesn't yet resolve #131 because the plumbing in builder isn't there. I'll put my PR for builder up in a moment when i'm not on thumbs. |
|
Fair enough, I removed the resolution! And sorry if I was stepping on toes! :( |
|
I'd hold off on merging this till we have a complete solution |
|
Not at all @skylerto! Love that you hopped on it!!! |
Signed-off-by: skylerto <[email protected]>
scripts/provision.sh
Outdated
| @@ -89,6 +89,7 @@ provider = "$OAUTH_PROVIDER" | |||
| userinfo_url = "$OAUTH_USERINFO_URL" | |||
| token_url = "$OAUTH_TOKEN_URL" | |||
| redirect_url = "$OAUTH_REDIRECT_URL" | |||
| signup_url = "$OAUTH_SIGNUP_URL" | |||
There was a problem hiding this comment.
I believe this line is NOT needed as we don't have a signup_url config in builder-api at all
There was a problem hiding this comment.
Thats correct. My apologies @skylerto last week after we dug into this a bit more we found this has no effect so you can remove it and then we're g2g!
There was a problem hiding this comment.
awesome, just pushed a revert!
|
@skylerto Pls see my comment above |
This reverts commit ce454ab.
Adds support for the
oauth_signup_urlvia thebldr.env.samplefile.I wasn't sure how to handle the other auth providers (azure-ad, okta, chef-automate) as users are managed at a different level then a straight forward signup, hence there are no examples in the
bldr.env.sample.Thinking how I would set this link if I were using one of the missing providers (azure-ad, okta, chef-automate) I would likely suggest a link to some type of on-boarding documentation.
Signed-off-by: skylerto [email protected]