Fixes silent package sync uploading failures #158
Conversation
|
Nice! For posterity it would be good to add more explanation of the breakage and changes. |
eeyun
force-pushed
the
eeyun/sync_fixes
branch
4 times, most recently
from
27c4763 to
5238e50
Compare
|
Ok, so, let me break down why this change exists. First, this fixes #153 . Second it turned out there were a couple of silent failure cases in the sync script. At some point in the last few months we changes the API for upload endpoints to need a package's target. Via the hab cli this is never a problem since the package target is a bit of metadata the client can glean and pass along on upload. Since the sync script needs to be able to upload the full set while avoiding the "this package's deps don't exist" error, we use curl. Doing so means the script had a hand rolled POST statement and we needed to update the statement to include the package target. Next, I found that in cases where a distro has a b2sum binary that ships with it, the flags from the go binary we referenced in the docs did not match the flags from the binary shipped by blake2 themselves. As such it was possible for a second silent failure in which the incorrect flag would be passed to generate the package checksum. Now, we use the default flags from the common binary AND any of the binary utilities we use in the script are now explicitly executed as habitat packages rather than relying on the underlying distro. |
| @@ -220,6 +228,10 @@ read_base_plans() { | |||
| done < base-plans.txt | |||
| } | |||
|
|
|||
| read_hab_plans() { | |||
| hab_plans=( "hab-sup" "hab-launcher") | |||
There was a problem hiding this comment.
Will this also cover hab-backline as an automatic dependency?
There was a problem hiding this comment.
It will for a full sync. This stanza is only used with the base-plans flag.
Signed-off-by: Ian Henry <[email protected]>
This change fixes the silent upload failure and adds the hab-sup and hab-launcher to the base-plans only syncing mechanism.
Signed-off-by: Ian Henry [email protected]