Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign up here" link takes you to github when auth is configured for Chef Automate #131

Open
ericcalabretta opened this issue Mar 14, 2019 · 3 comments
Labels
A-builder C-chore Chore item V-bldr Builder vertical

Comments

@ericcalabretta
Copy link
Contributor

The "Don't have a Chef Automate account?" section links you to github when auth is configured to Chef Automate

image

this page is located at BuilderURL/#/sign-in

@dmccown dmccown added A-builder C-bug Something isn't working V-bldr Builder vertical labels Apr 2, 2019
@eeyun
Copy link
Contributor

eeyun commented Jul 11, 2019

@ericcalabretta this is actually a tunable value in the habitat.conf.js we use for the front end of builder. You can find the configuration point here: https://github.com/habitat-sh/builder/blob/master/components/builder-web/habitat.conf.sample.js and The builder-web readme explains a bit of how to do this but generally this can be set in builder's svc config. I'll update what we have in the builder repo and the config generation bits here before I close this issue out.

@eeyun eeyun added C-chore Chore item and removed C-bug Something isn't working labels Jul 11, 2019
@ericcalabretta
Copy link
Contributor Author

That's great news! Is it just missing from the on-prem builder readme or the bldr.env.sample file?

I read that link but the setting for the redirect wasn't obvious to me.

@skylerto
Copy link
Contributor

skylerto commented Jul 12, 2019

@ericcalabretta I believe the property can be set via updating the user.toml file for builder-api-proxy service:

[oauth]
signup_url = "..."

But yes looks like you're right, it's not exposed in the bldr.env.sample and the provisioning of the builder-api-proxy user.toml doesn't show override that value.

ref: https://github.com/habitat-sh/builder/blob/master/components/builder-api-proxy/habitat/config/habitat.conf.js#L20

ref: https://github.com/habitat-sh/on-prem-builder/blob/master/scripts/provision.sh#L120-L149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder C-chore Chore item V-bldr Builder vertical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants