Release SAAS builder built against LTS-2024 dependencies #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougata-progress
force-pushed
the
sougata/saas_builder
branch
from
b2628d0 to
eecf504
Compare
sougata-progress
requested review from
mwrock and
sajjaphani
as code owners
mwrock
requested changes
Sep 25, 2024
There was a problem hiding this comment.
The key changes here looks like they are directed for the local dev experience via make. That makes sense to keep but the key intent here is what our CI builds. This GH action controls how components are built on merge. These components need to be build against LTS.
This also doesn't seem to impact the verify pipeline. we want to make sure that pipeline uses LTS.
sougata-progress
force-pushed
the
sougata/saas_builder
branch
3 times, most recently
from
64b6d08 to
7f802b5
Compare
sougata-progress
force-pushed
the
sougata/saas_builder
branch
from
422ca55 to
47ec2a1
Compare
mwrock
requested changes
Oct 11, 2024
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
Signed-off-by: Matt Wrock <[email protected]>
Signed-off-by: sougata-progress <[email protected]>
mwrock
force-pushed
the
sougata/saas_builder
branch
from
06d883b to
1fd3816
Compare
mwrock
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story : https://chefio.atlassian.net/browse/CHEF-15035