-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder work end to end - main #1737
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
@@ -19,6 +19,8 @@ pipelines: | |||
- verify: | |||
description: Pull Request validation tests | |||
public: true | |||
- end_to_end: | |||
description: Builder end to end test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a trigger for this. How does it get run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it manually until we discuss when we want to kick this off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have a pipeline set up on buildkite yet.
.expeditor/end_to_end.pipeline.yml
Outdated
@@ -0,0 +1,35 @@ | |||
expeditor: | |||
secrets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't looke like these secrets are being used. Do we need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaning up
.expeditor/end_to_end.pipeline.yml
Outdated
account: github/habitat-sh | ||
field: token | ||
accounts: | ||
- aws/habitat # for uploading the bootstrap bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like this is used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaning up
.expeditor/end_to_end.pipeline.yml
Outdated
HAB_BLDR_CHANNEL: "unstable" | ||
BUILD_PKG_TARGET: "x86_64-linux" | ||
PIPELINE_HAB_BLDR_URL: "https://bldr.habitat.sh" | ||
GITHUB_USER: "habitat-sh" # per https://github.com/github/hub/issues/2264#issuecomment-567241335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably only pull in what we use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaning up
.expeditor/end_to_end.pipeline.yml
Outdated
docker: | ||
environment: | ||
- GITHUB_USER | ||
soft_fail: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really want soft_fail
? If this is the only test and it is set to soft_fail
then the pipeline will never fail.
test/end-to-end/worker-test/.env
Outdated
@@ -0,0 +1 @@ | |||
HAB_AUTH_TOKEN=_Qk9YLTEKYmxkci0yMDE3MDkyNzAyMzcxNApibGRyLTIwMTcwOTI3MDIzNzE0CnB4Wi9vdGZXOE5Oc2hwOE1xa3ZTKzF4NkxpMDVQSGltCk5lMlFZTElOV3dMZGViY0EwaEVCbXB4ZmsrK29rRWNnZHhJOTNweEtNSjVCQVpDZg== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this map to a real token? I'm unclear how this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file accidentally got pulled in - will remove.
global.mystiqueBearer = 'Bearer mystique'; | ||
global.hankBearer = 'Bearer hank'; | ||
global.weskerBearer = 'Bearer wesker'; | ||
global.lkennedyBearer = 'Bearer lkennedy'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use all of these? Probably boboBearer
but I'm not sure what the others are for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will clean these up. Only using one - "bobo"
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
Refactored - note that this requires HAB_FUNC_TEST=1 in builder-worker code to be deployed