Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder work end to end - main #1737

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Builder work end to end - main #1737

wants to merge 9 commits into from

Conversation

pozsgaic
Copy link
Contributor

Refactored - note that this requires HAB_FUNC_TEST=1 in builder-worker code to be deployed

pozsgaic added 5 commits May 23, 2022 16:59
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
@@ -19,6 +19,8 @@ pipelines:
- verify:
description: Pull Request validation tests
public: true
- end_to_end:
description: Builder end to end test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a trigger for this. How does it get run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it manually until we discuss when we want to kick this off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have a pipeline set up on buildkite yet.

@@ -0,0 +1,35 @@
expeditor:
secrets:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't looke like these secrets are being used. Do we need them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning up

account: github/habitat-sh
field: token
accounts:
- aws/habitat # for uploading the bootstrap bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like this is used here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning up

HAB_BLDR_CHANNEL: "unstable"
BUILD_PKG_TARGET: "x86_64-linux"
PIPELINE_HAB_BLDR_URL: "https://bldr.habitat.sh"
GITHUB_USER: "habitat-sh" # per https://github.com/github/hub/issues/2264#issuecomment-567241335
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably only pull in what we use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning up

docker:
environment:
- GITHUB_USER
soft_fail: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want soft_fail? If this is the only test and it is set to soft_fail then the pipeline will never fail.

@@ -0,0 +1 @@
HAB_AUTH_TOKEN=_Qk9YLTEKYmxkci0yMDE3MDkyNzAyMzcxNApibGRyLTIwMTcwOTI3MDIzNzE0CnB4Wi9vdGZXOE5Oc2hwOE1xa3ZTKzF4NkxpMDVQSGltCk5lMlFZTElOV3dMZGViY0EwaEVCbXB4ZmsrK29rRWNnZHhJOTNweEtNSjVCQVpDZg==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this map to a real token? I'm unclear how this works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file accidentally got pulled in - will remove.

global.mystiqueBearer = 'Bearer mystique';
global.hankBearer = 'Bearer hank';
global.weskerBearer = 'Bearer wesker';
global.lkennedyBearer = 'Bearer lkennedy';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use all of these? Probably boboBearer but I'm not sure what the others are for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will clean these up. Only using one - "bobo"

pozsgaic added 4 commits June 10, 2022 17:25
Signed-off-by: pozsgaic <[email protected]>
Signed-off-by: pozsgaic <[email protected]>
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants