Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change existingResponse from PassThrough to Auto #30

Closed

Conversation

rexcfnghk
Copy link
Contributor

In ASP.NET MVC, PassThrough will serve a blank page when we serve a >4XX
response (e.g. using return new HttpStatusCode(HttpStatusCode.Forbidden)) even when a route is set for 403 errors. By reverting to Auto, the view will be correctly rendered.

In ASP.NET MVC, PassThrough will serve a blank page when we serve a >4XX
response (e.g. using `return new
HttpStatusCode(HttpStatusCode.Forbidden)`) even when a route is set for
403 errors. By reverting to Auto, the view will be correctly rendered.
@rexcfnghk rexcfnghk closed this Mar 2, 2016
@rexcfnghk rexcfnghk deleted the feature/fix-http-errors-handling branch March 2, 2016 02:14
@rexcfnghk
Copy link
Contributor Author

Will open the PR again once I rebased my commits

@ChrisMcKee
Copy link
Member

Cool; slow reply I know.
Ideally we want to add a comment above the line with the parameter in and why you might remove it as it helps people make their own choices / debug their own issues along the way.
Try and avoid whitespace changes if you can :)

Thanks

@rexcfnghk
Copy link
Contributor Author

The new PR is on #31 👍 Let me tidy up the commit and remove the whitespaces. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants