GH-16420: change default values from -1 to the actual default values. #16421
+112
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f users set more parameters than needed.
…eck for setting extra parameters.
maurever
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thanks, @wendycwong, for this PR. I have just one question. Otherwise LGTM.
| @@ -134,44 +132,43 @@ public static final class InfogramParametersV3 extends ModelParametersSchemaV3<I | |||
| level = API.Level.secondary, gridable=true) | |||
| public String[] protected_columns; | |||
|
|
|||
| @API(help = "A number between 0 and 1 representing a threshold for total information, defaulting to 0.1. " + | |||
| @API(help = "A number between 0 and 1 representing a threshold for total information. " + | |||
There was a problem hiding this comment.
I think you should keep information about the default value.
Or what is the reason for removing it from this doc string in InfogramV3?
There was a problem hiding this comment.
@maurever : I just notice this new thing. If you set it to a value in InfogramModel.java in the parameters, the default will will apear.
I just took a picture of infogram.R.
If I add "default o 0.1", then in infogram.R, you will see two default values settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the issue: #16420
Previous thoughts are:
There are two sets of parameters to set for each infogram mode: for fairness or for core.
Hence, I set the parameters to -1 to indicate that users have not set more parameters than they should.
However, thinking back here, it is more important to set the parameters to the correct values than reprimanding them if they set more parameters than they should. Hence, I just go in and set the parameters to their default values instead of -1.