Make Stream's destructor public. #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A public destructor is needed to move around streams with their interface pointers (or std::unique_ptr<Stream>) instead of the specific implementation.
PieroV
force-pushed
the
stream-public-destructor
branch
from
47baf3d
to
d520c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
ozz::io::Stream's destructor public.The use case is having a function that returns a generic
std::unique_ptr<ozz::io::Stream>which will be automatically destructed when the consumer is done with it without having to make assumption on the stream type.If the constructor is
protected/private, alsostd::unique_ptrcannot access it and the program fails to build.